Improve translations in diagnostics, update translation domain #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
force-pushed
the
translation-fixes
branch
from
dc5d899 to
59f1a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Follow up after #557.
Code changes
_instead of-trans.__callsColumnto have a separateidandlabelUser-facing changes
Translations should work, and should cover the diagnostics panel now.
get_breadcrumbswas renamed togetBreadcrumbs;get_breadcrumbswas retained for backwards compatibility but is now deprecated in favour ofgetBreadcrumbsand will be removed in 4.0.Backwards-incompatible changes
None
Chores